lan-application.json files (EN/ES) updating and hard-coded strings detection

[marioalmonte]

app.assetmanagement is duplicated. Deleted the second one.

[canstudios-louisem]

related: #1715

[canstudios-louisem]

If this is going in we probably should update the grunt file so that it can be used

[marioalmonte]

Indeed. For now it's a little tricky to translate. gruntfile line 10 must be modified: src: ['routes/lang/es-application.json','frontend/src/plugins/**/lang/es.json'], and do grunt build. EN.json file will translate, so it isn't a clean change.

[canstudios-louisem]

I've quickly hacked together a patch for the grunt changes and language detection it should try and detect your browser language but it's not easy for me to test as a monolingual English speaker. Feel free to test it and commit it to your pr if it works.

[tomgreenfield]

Would you mind changing the hardcoded text "Plugin management" to Origin.l10n.t('app.pluginmanagement') here please?

Note: the unlocalised dashboard titles are fixed in https://github.com/adaptlearning/adapt_authoring/pull/1614.

[marioalmonte]

@canstudios-louisem Must I add that code at the end of grunt file?

[canstudios-louisem]

@mariogalmonte it's a git patch if you're not sure what to do with it don't worry I'll add another pr with it.

[marioalmonte]

@canstudios-louisem I have tried to do the patch:

1. Rebuild develop version (original gruntfile ). sudo grunt build
2. Apply patch: sudo git apply --stat lang.patch console shows:

.gitignore                |    1 +
 Gruntfile.js              |    9 +++++++++
 frontend/src/core/l10n.js |   26 +++++++++++++++++++++++++-
 3 files changed, 35 insertions(+), 1 deletion(-)

4. sudo node server. But Adapt (ES Mozilla Firefox) is in English. Maybe I've done something bad?

[canstudios-louisem]

@mariogalmonte try a grunt build and then node server after applying the patch if not my language checking code may not be doing what I expected.

[marioalmonte]

@canstudios-louisem . It doesn't work too. I've done: git apply --stat lang.patch, grunt build, node server Tested in Mozilla Firefox and Google Chrome. Ubuntu 14 LTS 64 bits

[canstudios-louisem]

Ok for now just carry on as you were with your change to the grunt file. Ill make this into a proper pr.

[marioalmonte]

Ok. Thanks!