adapt_authoring icon indicating copy to clipboard operation
adapt_authoring copied to clipboard

Create nl-application.json

Open johnniezen opened this issue 8 years ago • 7 comments

Translation for Dutch language I have some errors in the file on lines 111~123, 136, 138, 317 and 318. Not sure and able how to fix.

johnniezen avatar Jan 19 '17 08:01 johnniezen

Many thanks for the PR John!

Couple of things:

  • Which commit did you base the translation on? It doesn't seem to match the latest in the master branch; the references to Learning Pool and Adapt Builder in particular caught my eye.
  • We're very close to releasing a new version of the tool (i.e. days away) which will introduce some new language strings. Would be great if you could add these to your PR.

taylortom avatar Jan 19 '17 11:01 taylortom

Hello Tom, if the strings are already available, please sent them, or point me were to get them and I’ll add them in the current one.

As for where they came from, the file could be a little older, like from September or October, when I wanted to make a first start. Never really managed to get some minutes to finish. When I noticed the ES PR recently, I compared that with mine.

If there are any mix ups, or deletions needed, just tell me so.

johnniezen avatar Jan 19 '17 11:01 johnniezen

Thanks John!

You'll find the latest version of the file here. You can see the latest amends in-place by looking at the file's blame page (this may or may not be useful!).

taylortom avatar Jan 23 '17 10:01 taylortom

Thanks Tom, I compared the files, and a I could only see the difference in the last 4 lines, which are removed. Hope it is all good now.

johnniezen avatar Jan 23 '17 11:01 johnniezen

@johnniezen I've just set up a quick test, and still getting differences (sorry!). Have set up this gist which will hopefully be of some help.

taylortom avatar Jan 28 '17 12:01 taylortom

Hi Tom, You gist was really helpfull. Hope to have captured all differences now. Thank you and Tom Greenfield for all the support sofar. Slowly getting to learn this, but I like it.

johnniezen avatar Feb 03 '17 18:02 johnniezen

Not sure if this is still in Sync. Also looking at the Merging comment, I need to assign 2 approving reviewers. Github help notes something about using a q, but does not specify how the syntax should be. Anyone to make a similar Gist for my like Tom Taylor did (see a little higher) and tell me how to add reviewers (or volunteer)

johnniezen avatar Dec 20 '18 12:12 johnniezen