adapt-cli icon indicating copy to clipboard operation
adapt-cli copied to clipboard

Add npm layer

Open oliverfoster opened this issue 3 years ago • 0 comments

Subject of the issue

All commands should work as they currently do, except that the Adapt Framework plugins should be installed using the npm client in the src/ folder with src/package.json rather than in the src/[pluginType] folders using bower and adapt.json.

SECURITY NOTE: npm install should be performed using --ignore-scripts such that no code is executed on plugin installation (AAT security). Client-side code is installed in the src/ folder so that it can not have impact on the execution of the builder.

root
├── node_modules                         Builder modules 
├── package.json                            Builder dependencies only (grunt, babel, eslint etc)
└── src
    ├── node_modules                     Client-side modules (react, adapt plugins, etc)
    └── package.json                        Client-side dependencies only (adapt plugins)   

Unresolved issues

  • AAT zip uploads and npm install pruning
  • adapt.json and its relationship to src/package.json
  • What to do with the bower registry

Other

Prototype adapt framework lives here, prototype plugins live here

oliverfoster avatar Mar 15 '21 12:03 oliverfoster