adapters icon indicating copy to clipboard operation
adapters copied to clipboard

PLbart support

Open FahadEbrahim opened this issue 1 year ago • 2 comments

Hi,

This is a PR to add the PLBART model written in the following paper. The original code is available at the following link. It follows the BART architecture, so, I followed the same style.

This is my first PR, so apologies in advance for any errors and I'd appreciate your feedback and guidance.

Thanks, Fahad.

FahadEbrahim avatar Jun 23 '24 16:06 FahadEbrahim

Hey @FahadEbrahim,

Thank you so much for working on this! We'll look into your PR more closely in the coming days. In the meantime, it would be great if you could continue to work on making the failing checks passing and let us know if you need any help on that!

calpt avatar Jun 24 '24 21:06 calpt

Thank you @calpt for your kind reply.

The testing of the models and the methods were successful. But I'd appreciate your review conceptually (if there are differences between PLBart and BART that I'm unaware of)

I was having an issue with the first test of code quality. It was due to not cloning the repo recursively. It's been fixed now.

FahadEbrahim avatar Jun 25 '24 15:06 FahadEbrahim

Thank you @calpt for reviewing the PR. The conflict has been fixed. Please let me know if anything can be modified.

FahadEbrahim avatar Jul 07 '24 12:07 FahadEbrahim