adapters icon indicating copy to clipboard operation
adapters copied to clipboard

Published 20 hours ago • verified publisher icon adapter-hub

Add Support for Electra

Open amitkumarj441 opened this issue 2 years ago • 2 comments

Support architecture proposed in Electra: Pre-training text encoders as discriminators rather than generators

amitkumarj441 avatar Aug 05 '22 00:08 amitkumarj441

Hey @amitkumarj441, thanks a lot for working on this! While there are still a few tests failing currently, I did a partial review of your changes and left some comments. All in all, it looks very good.

Besides fixing the missing tests, please have look at our contribution guide for the required documentation steps for a new model. Let me know if anything is unclear or you need any assistance from our side!

Thanks @calpt for reviewing this PR. I will make changes as suggested soon.

amitkumarj441 avatar Sep 06 '22 12:09 amitkumarj441

Any update soon?

pauli31 avatar Oct 10 '22 08:10 pauli31

Hey, thanks for your work on this. We have been working on developing a new adapters version of the library which is decoupled from the transformers library (see #584 for details). We want to add Electra support to the adapters library and started implementing the support based on this PR in #583.

hSterz avatar Sep 05 '23 11:09 hSterz

Closing in favor of #583.

calpt avatar Sep 05 '23 20:09 calpt