adapters icon indicating copy to clipboard operation
adapters copied to clipboard

Support for transformer in adapter

Open amitkumarj441 opened this issue 2 years ago • 3 comments

amitkumarj441 avatar May 28 '22 17:05 amitkumarj441

Hey @amitkumarj441, thanks for working on the integration of adapters into the Transformer model, very looking forward to your contribution! To make sure the model integration is complete and working as expected, please make sure to follow our model contributing here as closely as possible. Please let us know if you need any help from our side. Thanks!

calpt avatar Jun 14 '22 08:06 calpt

Hey, thanks again for your efforts in contributing new model architectures to adapter-transformers and sorry for the silence on our side.

In the last few weeks, we've been working on a large refactoring of our project, which will ultimately result in the release of Adapters, the next-generation adapters library. See https://github.com/adapter-hub/adapter-transformers/issues/584.

As a consequence, we plan to merge any new model integrations directly to the new codebase, which currently can be found on this branch. Unfortunately, this necessitates some changes in the model integration code (detailed here, see already integrated models such as BERT, BART etc. for reference).

If you'd be willing to update your model integration to target the new library yourself, we'd be super happy to help you on this. Otherwise, we might look into upgrading and merging some of the open model integration PRs ourselves in the future. For more details, again see https://github.com/adapter-hub/adapter-transformers/issues/584.

calpt avatar Sep 09 '23 09:09 calpt

Hey, thanks again for your efforts in contributing new model architectures to adapter-transformers and sorry for the silence on our side.

In the last few weeks, we've been working on a large refactoring of our project, which will ultimately result in the release of Adapters, the next-generation adapters library. See #584.

As a consequence, we plan to merge any new model integrations directly to the new codebase, which currently can be found on this branch. Unfortunately, this necessitates some changes in the model integration code (detailed here, see already integrated models such as BERT, BART etc. for reference).

If you'd be willing to update your model integration to target the new library yourself, we'd be super happy to help you on this. Otherwise, we might look into upgrading and merging some of the open model integration PRs ourselves in the future. For more details, again see #584.

Hi @calpt,

Thanks for letting me know about the refactoring updates.

I will have a look at the alterations in the new library and will see if I can update my existing PRs or potentially initiate new PRs.

amitkumarj441 avatar Sep 21 '23 06:09 amitkumarj441