flower icon indicating copy to clipboard operation
flower copied to clipboard

Cpp v2

Open pedropgusmao opened this issue 3 years ago • 3 comments

Final tests with the CPP implementation

pedropgusmao avatar Sep 10 '21 09:09 pedropgusmao

Libtorch example finished

scylj1 avatar Jan 05 '22 14:01 scylj1

@scylj1 Thank you again for this great work. A few todo's as discussed previously:

  • [ ] Add client code for secure connection which was merged here: #844 also we can think of adding this as a subsequent PR if it increases complexity too much. Beware that there where some additional PR's after #844 so ideally checkout the code in main.
  • [ ] Use clang-format-10 for C++ code. It is currently used for the protobufs. See here
  • [ ] Add the default copyright header to all files in src as can be seen here

I will do a code review sometime today and give a bit more feedback.

tanertopal avatar Jan 14 '22 10:01 tanertopal

I believe we do not have a get_properties() implementation yet.

pedropgusmao avatar Jan 24 '22 19:01 pedropgusmao