flower icon indicating copy to clipboard operation
flower copied to clipboard

Adding logging of exceptions when clients are called asynchronously

Open amm299 opened this issue 4 years ago • 1 comments

amm299 avatar Jul 27 '21 15:07 amm299

@amm299 could you explain the motivation behind the PR and detail what it does?

tanertopal avatar Mar 22 '22 17:03 tanertopal

@amm299 Thank you for opening the PR. Closing it for now due to inactivity, but I am happy to reopen it if you want to continue working on it. Feel free to ping me on Slack with a reference to this PR.

tanertopal avatar Sep 22 '23 21:09 tanertopal

Hi Taner, It's been 2 (3?) years since I worked on Flower, so I've forgotten all of the details. The essential problem, as I recall, was that when you spawned a bunch of processes with Ray (I think that's what it was called), so you could perform federated learning, these processes weren't tied to the command line of the main process. Thus, any logs or error messages would not be displayed, and so the code could fail silently. I made some changes to the code so that these logs/error messages would be displayed, which made debugging much easier. I don't know if any of this is relevant at this point, but I thought I should explain the problem I was trying to solve.

Best, Angus ------- Original Message ------- On Friday, September 22nd, 2023 at 22:05, Taner Topal @.***> wrote:

Closed #796.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

amm299 avatar Sep 29 '23 02:09 amm299