flower icon indicating copy to clipboard operation
flower copied to clipboard

Enabling flwr_datasets to work with custom (not on Hugging Face Hub) Dataset

Open gubertoli opened this issue 1 year ago • 2 comments

Issue

The flwr_datasets is not able to working with custom loaded datasets even when compliant with Hugging Face Dataset format,

Description

Enable the loading of custom datasets not available in the Hugging Face Hub.

Related issues/PRs

This PR tries to give a solution for issue #3201

Proposal

Explanation

Work in progress.

Checklist

  • [x] Implement proposed change
  • [ ] Write tests
  • [ ] Update documentation
  • [x] Update the changelog entry below
  • [x] Make CI checks pass
  • [x] Ping maintainers on Slack (channel #contributions)

Changelog entry

gubertoli avatar Apr 04 '24 07:04 gubertoli

Hi @gubertoli !

Thank you for your work on this PR. I've encountered the same issue and I want to improve it. If you're okay with it, I'd be happy to continue working on this and help get it merged. Please let me know what you think.

Thanks!

kuchidareo avatar Sep 29 '24 12:09 kuchidareo

Hi @gubertoli !

Thank you for your work on this PR. I've encountered the same issue and I want to improve it. If you're okay with it, I'd be happy to continue working on this and help get it merged. Please let me know what you think.

Thanks!

Hi @kuchidareo, any help is welcome. A point of attention is that Flower Datasets evolved since this PR was sent. My suggestion would be to have a look at this doc entry. Even though the issue #3201 is still open, a re-check would be useful. To solve my problem, I used the flower with these changes, but currently I am not working on it.

Overall, feedback from the Flower team would be essential to see if it makes sense: @adam-narozniak @jafermarq

gubertoli avatar Sep 30 '24 14:09 gubertoli