Andreas Dangel

[java] UnusedPrivateMethod - false positive with static methods

3

**Affects PMD Version:** 7.0.0 **Rule:** [UnusedPrivateMethod](https://docs.pmd-code.org/latest/pmd_rules_java_bestpractices.html#unusedprivatemethod) **Description:** The regression tester shows, that the rule finds the following allegedly unused private methods: - https://github.com/openjdk/jdk/tree/jdk-11+28/src/java.base/share/classes/java/lang/Integer.java#L170 'toStringUTF16(int, int)' - https://github.com/openjdk/jdk/tree/jdk-11+28/src/java.base/share/classes/java/lang/Integer.java#L338 'toUnsignedString0(int, int)' -...

**Affects PMD Version:** since 6.31.0 **Description:** When PMD is run under Windows, the URIs in the SARIF report look like ```json "artifactLocation": { "uri": "D:\\a\\pmd-github-action-test\\src\\classes\\UnusedLocalVariableSample.cls" }, ``` This is not...

**Affects PMD Version:** 7.0.0 **Description:** As found in #3645, currently we can't process [InputJavaParserNoFreezeOnDeeplyNestedLambdas](https://github.com/checkstyle/checkstyle/blob/checkstyle-9.1/src/test/resources-noncompilable/com/puppycrawl/tools/checkstyle/javaparser/InputJavaParserNoFreezeOnDeeplyNestedLambdas.java). > Type checking nested lambdas is exponential IIRC, here there should be 6^31 overload combinations to...

GitHub Actions, Building, PR, and Releasing Questions

8

Hi @jandroav, as a liquibase extension maintainer, I have now a couple of questions regarding the build workflow. Since you committed last in this area, I hope, you can help....

1. Rename [milestone](https://github.com/pmd/pmd-github-action/milestones) "next" to new version, e.g. "v1.0.1", close it, and create a new "next" milestone 2. Push a tag with a full semantic version, e.g. "v1.0.1" 3. [Draft...

Optionally create review comments

2

With #7 inline annotations are created, but they can't be commented or resolved. The PMD GitHub Action could add comments for each found violation when running on a pull request....

Currently the unit tests test everything except index.js. Would be good to have an automated integration test. Currently https://github.com/pmd/pmd-github-action-tests is used for a manual test

Support equivalent of failurePriority

1

You can configure a specific priority for each rule in your own ruleset (https://pmd.github.io/latest/pmd_userdocs_configuring_rules.html#message-and-priority-overriding). The maven-pmd-plugin supports the parameter [`failurePriority`](https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html#failurePriority) which can used to fail the build only for "high...

This action calls PMD and PMD requires a Java runtime for execution. In the README.md the following basic configuration is suggested: ```yaml steps: - uses: actions/setup-java@v2 with: distribution: 'temurin' java-version:...

See https://docs.github.com/en/rest/reference/checks The advantage over the currently implemented build annotations (#7) is, that we can mark the build as failed directly. This would make the extra build step, to make...