prettier-plugin-erb icon indicating copy to clipboard operation
prettier-plugin-erb copied to clipboard

Handle 2.3 prettier changes

Open adamzapasnik opened this issue 3 years ago • 6 comments

adamzapasnik avatar May 25 '21 05:05 adamzapasnik

Issues thanks to incompatibility of prettier 2.3 and above: https://github.com/adamzapasnik/prettier-plugin-erb/issues/97 https://github.com/adamzapasnik/prettier-plugin-erb/issues/44 https://github.com/adamzapasnik/prettier-plugin-erb/issues/97

Juice10 avatar Oct 04 '22 20:10 Juice10

Here are some upgrades to 2.8.0, but still failing in tests: https://github.com/amkisko/prettier-html-templates - all the issues are visible in tests now https://github.com/amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

UPD 27.01.2024: these repositories are removed.

amkisko avatar Jan 18 '23 15:01 amkisko

@amkisko great to see this. Does it already make sense for you to share a Work-in-progress (WIP) Pull Request? Maybe in collaboration with @Juice10, who also started a similar Pull Request

tmaier avatar Jan 28 '23 17:01 tmaier

@tmaier @Juice10 you are welcome:

  • https://github.com/adamzapasnik/prettier-html-templates/pull/56
  • https://github.com/adamzapasnik/prettier-plugin-erb/pull/135

It seems that there are some complex problems to solve. :)

amkisko avatar Jan 30 '23 08:01 amkisko

Here are some upgrades to 2.8.0, but still failing in tests: amkisko/prettier-html-templates - all the issues are visible in tests now amkisko/prettier-plugin-erb - this one is more complex due to changes in prettier and at the moment in tests it always returns 0 bytes output

Hi @amkisko – why did you delete the amkisko/prettier-html-templates fork?

Did you give up and prettier-plugin-html-erb is the replacement?

drewlustro avatar Jan 27 '24 00:01 drewlustro

Yes, I did, although PRs are still available, no more changes happened after publishing.

There are few better options available:

  • erb-lint (which also adds support for rubocop which is very useful)
  • erb-formatter
  • rewriting https://github.com/ecmel/prettier-plugin-ejs to support erb, which I did not continue too

amkisko avatar Jan 27 '24 08:01 amkisko