prettier-plugin-eex icon indicating copy to clipboard operation
prettier-plugin-eex copied to clipboard

Fix eexMultilineNoParens option

Open kelostrada opened this issue 2 years ago • 0 comments

If you try to add this option to .prettierrc.js then it blows up:

formatted_views/multiline.html.eex/bin/sh: --no-parens=${eexFormatterOptions.join(", ")}: bad substitution

[error] formatted_views/multiline.html.eex: Error: Command failed: /Users/bartosz/Projects/prettier-plugin-eex/prettier_eex_formatter_release CiAgbGlua190bygKICAgIGE6ICJiIiwKICAgIGM6ICJlIgogICk= IHNlbGVjdCBmLCA6bmFtZSwgWwogICAgICB7Om9wdGlvbiwgOnZhbHVlfQogICAgXQ== --line-length=98 --no-parens=${eexFormatterOptions.join(", ")}
[error] /bin/sh: --no-parens=${eexFormatterOptions.join(", ")}: bad substitution
[error] 
[error]     at checkExecSyncError (child_process.js:635:11)
[error]     at execSync (child_process.js:671:15)
[error]     at formatEex (/Users/bartosz/Projects/prettier-plugin-eex/lib/formatter.js:35:5)
[error]     at Object.print (/Users/bartosz/Projects/prettier-plugin-eex/lib/printers.js:23:27)
[error]     at callPluginPrintFunction (/Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14718:18)
[error]     at /Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14649:47
[error]     at Object.printComments (/Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14305:19)
[error]     at printGenerically (/Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14649:22)
[error]     at printAstToDoc (/Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14659:13)
[error]     at coreFormat (/Users/bartosz/Projects/prettier-plugin-eex/node_modules/prettier/index.js:14910:15)

This PR fixes the issue and add a small test case for this (just in elixir E2E, couldn't to find any test cases in JS for this...)

kelostrada avatar Mar 30 '22 12:03 kelostrada