Numeral-js icon indicating copy to clipboard operation
Numeral-js copied to clipboard

fix formatting of small numbers

Open thmaterna opened this issue 8 years ago • 9 comments

The multiplication done by appending ('e+' + boundedPrecision) would fail to yield a valid number ( 1e-8e+8 ), which would cause a 'NaN' to be the output.

#563

thmaterna avatar Oct 17 '17 14:10 thmaterna

I just noticed that the issue #563 was a duplicate of #514.

thmaterna avatar Oct 18 '17 12:10 thmaterna

It is also a duplicate of #512

thmaterna avatar Oct 18 '17 12:10 thmaterna

@thmaterna Having the same issue. Are you able to add @adamwdraper as a reviewer? @adamwdraper do you have time to review?

turnerniles avatar Nov 09 '17 20:11 turnerniles

@turnerniles github doesn't let me request a pull request review. I suppose @adamwdraper should have been notified when the pull request was created.

thmaterna avatar Nov 09 '17 20:11 thmaterna

Any updates on this?

perrosnk avatar Nov 29 '17 13:11 perrosnk

@adamwdraper the merges are not being accepted?

gullitmiranda avatar Apr 02 '18 17:04 gullitmiranda

can someone please merge the fix into master?

tab00 avatar Apr 11 '18 09:04 tab00

Bump

abartolo avatar Oct 22 '21 13:10 abartolo