bootforms icon indicating copy to clipboard operation
bootforms copied to clipboard

Support for Bootstrap 4

Open simplenotezy opened this issue 8 years ago • 8 comments

simplenotezy avatar Sep 09 '15 11:09 simplenotezy

I have started here: https://github.com/adamwathan/bootforms/pull/72

simplenotezy avatar Sep 09 '15 12:09 simplenotezy

Cool! I think we should probably make the Bootstrap 4 version a separate package so we don't break support for v3 though.

Currently even the switch to fieldset makes no difference, as the fieldset has no styles anyways, so a div looks the same. Let's wait until Bootstrap 4 is closer to release so we know what the final changes to the form markup will be and then fork this for a Bootstrap 4 version.

adamwathan avatar Sep 09 '15 12:09 adamwathan

The fieldset change defiantly makes a difference. Just tested it here. <div class="form-group"> breaks everything, whereas <fieldset class="form-group"> solves it.

Agreed on new package; can you create such, and we can start working already?

simplenotezy avatar Sep 09 '15 12:09 simplenotezy

This is a screenshot from the Bootstrap 4 docs, I changed some of these to divs and left some as fieldsets. Can you tell which ones are divs?

image

These are the styles applied by the fieldset:

image

div elements get those same styles by default.

Is it maybe only in the horizontal or inline layouts or something that things change?

adamwathan avatar Sep 09 '15 12:09 adamwathan

Yes I experienced this on horizontal form.

simplenotezy avatar Sep 16 '15 13:09 simplenotezy

Bootstrap 4 is considerably further along now — would you consider creating the separate package so development can start on bootforms for Bootstrap 4?

jeff-h avatar Mar 15 '17 20:03 jeff-h

Hey @jeff-h, I'm not actually using this package myself anymore and don't have any intention of adopting Bootstrap 4 on my own projects, but I'd happily support anyone who would like to fork this package to create a dedicated Bootstrap 4 version.

adamwathan avatar Mar 16 '17 00:03 adamwathan

Hi all,

I have been looking for an alternative (both BS 3 and BS 4) but so far I did not get much success.

The best I found was Spatie's package to produce HTML with some nifty functions.

So I have extended their package and will hopefully get to a 1.0 some time soon as I need this on a client project.

I would appreciate any contribution there to help make a decent alternative to this package that Adam has been kind enough to offer for so many years.

Here is the project for Bootstrap 4 helpers (currently about 70% done for forms, no version tagged yet) and a companion for Font Awesome (stable 1.0.3)

vpratfr avatar Nov 15 '17 17:11 vpratfr