bootforms icon indicating copy to clipboard operation
bootforms copied to clipboard

Published 20 hours ago • verified publisher icon adamwathan

add phpdoc to every method for autocompletion

Open bussnet opened this issue 7 years ago • 9 comments

add phpdoc for the methods, so with the barryvdh/laravel-ide-helper there is autocompletion with IDEs like PhpStorm

bussnet avatar Jul 05 '16 12:07 bussnet

Coverage Status

Coverage increased (+0.03%) to 90.909% when pulling 9abc0d30440752eb92fce9be935a65b7a2fd35ba on bussnet:master into c11c4184ed536e9d8ae7023e8b3fc87acfd128d9 on adamwathan:master.

coveralls avatar Jul 05 '16 12:07 coveralls

I think it could be handy if you adc the data type also.

Tjoosten avatar Jul 23 '16 13:07 Tjoosten

@Tjoosten What do you mean? What datatypes at what position?

@adamwathan Are you willing to merge this pull request? For us these changes are very important, cause the development time decreases extremly. Otherwise we use our own forked repository.

bussnet avatar Jul 24 '16 06:07 bussnet

Example:

/**

  • int $id */

2016-07-24 8:11 GMT+02:00 bussnet [email protected]:

@Tjoosten https://github.com/Tjoosten What do you mean? What datatypes at what position?

@adamwathan https://github.com/adamwathan Are you willing to merge this pull request? For us these changes are very important, cause the development time decreases extremly. Otherwise we use our own forked repository.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adamwathan/bootforms/pull/110#issuecomment-234760084, or mute the thread https://github.com/notifications/unsubscribe-auth/AE6y6Q0QrgrftRnINjY2JVnEvcLVqQbrks5qYwH6gaJpZM4JFFmV .

Tjoosten avatar Jul 24 '16 21:07 Tjoosten

Looks like some alignment is messed up on quite a few doc blocks. If that gets cleaned up I'm happy to merge for the greater good (despite my hatred for doc blocks! 😄)

image

adamwathan avatar Aug 02 '16 23:08 adamwathan

@adamwathan maybe we can fix this with a .editorconfig file in the repo

Tjoosten avatar Aug 02 '16 23:08 Tjoosten

Coverage Status

Coverage increased (+0.03%) to 90.909% when pulling 864ce751144813ef46851e487d68225b11bb1c58 on bussnet:master into c11c4184ed536e9d8ae7023e8b3fc87acfd128d9 on adamwathan:master.

coveralls avatar Aug 18 '16 18:08 coveralls

@adamwathan sorry for the messed format, my ide has used tabs before /** and spaces before the following * - stupid. It's now corrected @Tjoosten good idea with the datatypes, but alot of work.. this was a lot of automatic matching and is for the most cases helpfull enough.

bussnet avatar Aug 18 '16 18:08 bussnet

@bussnet @adamwathan please have a look at #144, I have fixed the merge conflict with this PR and also added support for Laravel 5.5 package auto-discovery.

Cheers @adamwathan for building this nifty package! :smile:

soham2008xyz avatar Jan 10 '18 09:01 soham2008xyz