django-appointment icon indicating copy to clipboard operation
django-appointment copied to clipboard

Support other language and jalali calendar

Open AmirMohammadDehghan opened this issue 1 year ago • 12 comments

Feature Description

Wow your package is really fantastic but it didn't support jalali or shamci calender and in our country miladi calender to book appointments not useful

The Ideal Solution

you can add jalali calender in your project and if you needed my help you can have it bro

The Current Solution

I suggest you to use this I found some useful resources: https://pypi.org/project/django-jalali-date/ https://stackoverflow.com/questions/42182989/jalali-calendar-in-fullcalendar https://github.com/mzangeneh/fullcalendar-shamsi

Additional Context

Add any other context or screenshots about the feature request here.

Are you willing to help with the implementation?

  • [x] Yes, I will contribute to the implementation of this feature.
  • [ ] No, I can't assist with the implementation, but I can provide feedback and guidance.

Priority

How important is this feature to you?

  • [x] Critical
  • [ ] High
  • [ ] Medium
  • [ ] Low

AmirMohammadDehghan avatar Mar 31 '24 04:03 AmirMohammadDehghan

Hi @AmirMohammadDehghan,

Thanks for the awesome feedback! Adding a Jalali calendar sounds like a great idea, especially for users in Iran and Afghanistan. I'm not too familiar with it, so it'd be fantastic if you could help out by making a pull request with the necessary changes. I can help review and guide you through it if needed.

What do you think?

adamspd avatar Apr 01 '24 13:04 adamspd

Hi @adamspd I am really interesting to contribute in this project in my free times and for this I need more information about how logic of this system work and structure of project and review codes for start integrate jalali calendrer before start we should think about how manage and make choice to use this both calendars since we need differ models and views and template and assets files and we should decide to use new models and view or we should integrate this present model and view with jalali

what do you think about this?

AmirMohammadDehghan avatar Apr 01 '24 18:04 AmirMohammadDehghan

So, you mean that in order to integrate it, new models are required ?

I will create a diagram of the models and of some use cases for you so you may have a better understanding.

adamspd avatar Apr 02 '24 13:04 adamspd

Thanks @adamspd I am not sure but maybe we should do it OK I am waiting for you bro

AmirMohammadDehghan avatar Apr 02 '24 13:04 AmirMohammadDehghan

I checked again model you used date time field for save dates but I think for jalai calendar is better to use jalali date field it have package and jalali calender week days start from Saturday we should be careful full about it

AmirMohammadDehghan avatar Apr 02 '24 13:04 AmirMohammadDehghan

I might have a few ideas, let me think about them and I will let get back to you once they are clearer in my head. In the meantime, if you have any questions, other than this issue, let me know.

You're used to coding with python, right ?

adamspd avatar Apr 02 '24 15:04 adamspd

OK I am waiting

Yes I am coding about 4 years as python programmer and 2 years I am working at web development as django programmer Yea I am familiar with python

AmirMohammadDehghan avatar Apr 02 '24 18:04 AmirMohammadDehghan

If I had other questions I'll ask you

AmirMohammadDehghan avatar Apr 02 '24 18:04 AmirMohammadDehghan

I will get back to you during the weekend.

adamspd avatar Apr 05 '24 00:04 adamspd

Ok

AmirMohammadDehghan avatar Apr 05 '24 09:04 AmirMohammadDehghan

Sorry it took me so long to respond to you. The only thing I can think of that would be a better solution would be to create an entirely separate package for jalali calendar. Unless you have a better idea.

I use fullcalendar to display the calendar, and while searching I found this equivalent of full calendar here. Not sure if it works 100%, but I wouldn't know until I try it locally. If it works, I'll let you know where you're going to find the code, and you can test it and add more to it if you'd like.

adamspd avatar Apr 10 '24 21:04 adamspd

Good I'd waiting for you

AmirMohammadDehghan avatar Apr 11 '24 03:04 AmirMohammadDehghan