Adam Sitnik

Results 315 comments of Adam Sitnik

I've marked the issue as up-for-grabs. Here are some hints for contributors interested in fixing the issue: * The tests for markdown exporter can be found [here](https://github.com/dotnet/BenchmarkDotNet/blob/master/tests/BenchmarkDotNet.Tests/Exporters/MarkdownExporterApprovalTests.cs). Simplest way of...

> I don't understand what done means if no code is merged, could you shed some light on the progress, I just can't tell if atomic append is moving forward...

@benaadams ![obraz](https://user-images.githubusercontent.com/6011991/117449839-bab31b80-af40-11eb-80ca-0fce7cb8c7f5.png)

@sebastienros how can I disable the events to get a clean trace file?

> How much micro benchmark coverage do we have for Extensions I would say that it's OK, we have dedicated micro benchmarks for Caching, DI, Http, Logging and Primitives. >...

> With Perfview, try /ClrEvents:None /TPLEvents:None I have tried that: ```cmd crank --config .\scenarios\platform.benchmarks.yml --scenario caching --profile aspnet-citrine-win --application.collect true --application.collectArguments "BufferSizeMB=1024;CircularMB=4096;TplEvents=None;ClrEvents=None" ``` But for some reason, it ends up...

> Updated from 2.0.66 to 2.0.68 After the update, I get a warning about 90%+ stacks being BROKEN. After solving the symbols, I can see that `EventSource.WriteEvent` is gone from...

With `TplEvents=None;ClrEvents:JitSymbols` I still get a complain about 90%+ stacks being BROKEN, but ETW is gone from the trace. ```cmd --application.collectArguments "BufferSizeMB=1024;CircularMB=4096;TplEvents=None;ClrEvents:JitSymbols" ```

@sebastienros could you please increase the timeout? I wanted to check if it reproes on Citrine, but I am getting the following error: ```log [03:06:17.163] Downloading trace file application.05-11-15-03-53.etl.zip ......