bap icon indicating copy to clipboard operation
bap copied to clipboard

Incorrect buffer size calculated

Open adamrenklint opened this issue 7 years ago • 0 comments

  • Consider a sample that is a perfect 1-bar loop (2 sec) at 120 bpm
  • We create a pattern with 60 bpm
  • We pitch the sample -12 semitones
  • We'd expect the pitched-down sample to be a perfect fit
  • But instead the sample will be too short, cut off too early

BufferHelper.getCopyLength does not take the playbackRate of a sample into consideration: https://github.com/adamrenklint/bap/blob/master/lib/BufferHelper.js#L73

adamrenklint avatar Oct 11 '17 19:10 adamrenklint