Adam Reichold

Results 536 comments of Adam Reichold

To be honest, the macro-based approach is a bit too magical for my taste. Scope/closure based API are a standard idiom when lifetimes need to be controlled so this change...

> Should be fixable with an #[allow(unsafe)], right? Yes, I think so. > We can maybe push this off for 0.7. I would be glad if we did as the...

> Is this to do with loading the elements into CPU registers or something? With contemporary systems, moving the data from memory into caches and registers often dominates the runtime...

> Should we add Miri to CI? :+1: For me, it found useful results in heavy-on-unsafe projects and doing it should be as simple as ```yaml - uses: actions-rs/toolchain@v1 with:...

I think I am hitting a similar issue where a location header that contains a path is parsed as an authority ``` [tests/path.rs:5] "forum".parse::().unwrap().into_parts() = Parts { scheme: None, authority:...

@nox Thank you for looking into this! Can you go into slightly more detail why both instances are valid behaviour so that I can better understand how to work around...

> The Uri type in that crate was mostly designed to represent a HTTP request target So basically, this boils down to `Uri` handling `request-target` but not `URI-reference` in the...

> on Unix any running processes are just likely to crash when they next need to load a segment of the native code. I think on Unix, you will get...

> I think when I've seen segfaults before it was for libraries rather than executables. Might behave differently? I think this mostly happens because updates are not transactional, e.g. an...

Indeed, the removal seems to be further along than I remembered from reading the article. Appears like I did not read it very thoroughly. 😊