Adam Raine

Results 320 comments of Adam Raine

https://bugs.chromium.org/p/chromium/issues/detail?id=1302667

At the end of every Lighthouse run, Lighthouse takes a screenshot of the entire page content, including content outside the normal viewport. To do this we resize the viewport to...

`startFlow` is the public API. We could add more pre-work to the `startFlow` function in a non-breaking release so it's safer to use `startFlow`. At the time of writing this...

Keeping this open as we need to discuss a long-term solution. `skipAudits: ['full-page-screenshot']` is just a workaround.

Before Lighthouse starts we make sure `window.performance.now` isn't writable anymore: https://github.com/GoogleChrome/lighthouse/blob/81689f134b2f3f2c3dc721d2f5b4475fe10bb593/core/gather/driver/execution-context.js#L236-L242 This is where the error is coming from. We could resolve this by using an isolated execution context for...

This is a bug in Lighthouse. Lighthouse should avoid errors due to modified globals as much as possible. That being said, an immediate workaround would be to update the site...

`narrow` SGTM. I did a quick test to see what `narrow` looked like for `ms` and it only removed the space. ![Screen Shot 2022-08-31 at 1 55 06 PM](https://user-images.githubusercontent.com/6752989/187780323-11394746-3b67-41eb-9354-630e9f68b74c.png) I'm...

> static analysis is difficult and by far the most effective/easiest way to test bfcache is to do an actual navigation. I believe that's how the DT panel does it...

TODO: Docs need updating Rest of this should be reviewable though.