WebMIDIKit icon indicating copy to clipboard operation
WebMIDIKit copied to clipboard

Published 20 hours ago • verified publisher icon adamnemecek

Remove assertion for disconnect

Open DivineDominion opened this issue 1 year ago • 1 comments

https://github.com/adamnemecek/WebMIDIKit/blob/6f3506937c141f04edaaa182502984d7baaa2e26/Sources/WebMIDIKit/MIDIPortMap.swift#L70

This assertion fires when you unplug a MIDI device of which a port is used.

I think removing this cause for runtime exceptions in DEBUG builds is a good fit (because the assumption that the device is still connected isn't always true!) and cannot gracefully be handled at all.

DivineDominion avatar May 10 '23 06:05 DivineDominion

@adamnemecek Gentle ping: what do you think about removing this?

DivineDominion avatar May 22 '23 13:05 DivineDominion