Pyrr icon indicating copy to clipboard operation
Pyrr copied to clipboard

Published 20 hours ago • verified publisher icon adamlwgriffiths

Bug/fix matrix apply to vector

Open mxrie-eve opened this issue 6 years ago • 3 comments

Purpose and Motivation

This pull request fixes #97 . The order of multiplication of the matrix and the vector in apply_to_vector was inverted. I added tests with 90 degrees rotations because the tests with rotation of 180 degrees do not highlight this type of error.

Types of changes

  • Bug fix
  • Breaking change

mxrie-eve avatar Nov 28 '19 19:11 mxrie-eve

Looks like this cascades into a number of other functions =/ https://travis-ci.org/adamlwgriffiths/Pyrr/builds/618337605

adamlwgriffiths avatar Nov 29 '19 05:11 adamlwgriffiths

Any updates here?

GavanWilhite avatar Sep 02 '20 22:09 GavanWilhite

Unfortunately the PR breaks more things.

On Wed, Sep 2, 2020 at 3:27 pm, Gavan Wilhite [email protected] wrote:

Any updates here?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/adamlwgriffiths/Pyrr/pull/98#issuecomment-686061514, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJOQ5ABZZW5HZS2HNSKK63SD3BGXANCNFSM4JSYGVWA.

adamlwgriffiths avatar Sep 02 '20 23:09 adamlwgriffiths