Adam J. Stewart

Results 884 comments of Adam J. Stewart

Closing/reopening to try to kick off CLA bot.

@microsoft-github-policy-service agree

The stack trace will tell them the full path the code took to raise that error (not necessarily clear to a non-programmer though). `root` isn't required, all datasets have a...

At the moment this is every dataset.

This is great, thanks so much! For torchvision dependency version, see what I did in #631 for the other trainers. It's possible to check the version of torchvision and use...

Another option would be to change the `pretrained` kwarg on our end so that instead of taking a boolean it takes whatever torchvision wants. Then it's up to the user...

Hmm, but then it becomes difficult to store this configuration in a YAML file...

But even if the YAML is torchvision > 0.12 specific, can you store objects in YAML or only strings/floats/bools? We could store a string and exec it but that feels...

Ah, we could use `torchvision.prototype.models.get_weight` to convert the string to the enum. But yeah, it would be a bit frustrating for the YAML to only work properly with torchvision 0.12....

We run tests on both the latest version of dependencies and the minimum version of dependencies. Both tests generate coverage reports, and should automatically be merged when uploaded to codecov....