Adam J. Stewart

Results 884 comments of Adam J. Stewart

We can train for multiple epochs in the tutorial, but use `fast_dev_run` in CI. The trainers tutorial does this with nbmake variable mocking. This also means we could use the...

If the tests are failing due to OOM then we'll have to do something like that. I think it will demonstrate how quick and easy it is to get a...

Interesting, I didn't realize that someone might want to use a leap day/month in this way. I wonder if we should just change 2001 to be a leap year. That...

Also, the logic you pointed out is only used to define the start of a fiscal calendar, not the end. Isn't is already possible to have a fiscal calendar that...

Yes, we could definitely modify `setup_fiscal_calendar` to accept either `start_*` _or_ `end_*` (but not both). If you want to submit a PR to make this change I'm happy to review....

It is actually currently possible to do this using the `fiscal_calendar` context manager. See https://fiscalyear.readthedocs.io/en/latest/advanced_usage.html#temporarily-changing-the-fiscal-calendar

That's true, we could redesign the API so that things like `START_YEAR`, `START_MONTH`, and `START_DAY` are attributes of every single object we create. Honestly, when I was designing this, I...

Can you add a `FiscalWeek` class and update the docs as well? Just want to be consistent with the other attrs.

Hmm, I see what you mean. This is getting pretty complicated. Let's go back to the original issue and try to decide on a single robust definition of what a...