Adam J. Stewart

Results 884 comments of Adam J. Stewart

I guess in order of priorities, I have: 1. It MUST install a stable version from a lock file, it CAN'T just install the latest version 2. I would prefer...

`node_modules` should be in `.gitignore`, IDE-specific things should not.

We should do this for all the datamodules you're using, not just these two.

Tests fail because the fake data consists of a single file and 10% of 1 is 0.

This PR adds 1K new files to git. Do we really need that many files?

> If we change the split portion from [0.8, 0.1, 0.1] to something like [0.6, 0.2, 0.2], we can reduce 50% of test images. We shouldn't change the default split...

@yichiac is this still needed?

I don't think the sampler is important here, the splitter is what's important. I just feel like most users will either use raw Sentinel-2 tiles or write their own NonGeoDataset...

@yichiac We should make a decision on this PR before the TorchGeo 0.6.0 release next week. Basically, it boils down to one question. Are these data modules designed for working...

PyTorch Lightning uses a fork of pytorch-sphinx-theme called [lightning-sphinx-theme](https://github.com/Lightning-Universe/lightning_sphinx_theme). However, this fork seems to have some of the same problems (no PyPI releases).