Adam J. Stewart

Results 884 comments of Adam J. Stewart

> The coverage drop seems to be caused by unrelated files. This usually means that coverage has increased in main since this branch was created. Usually, rebase or merge commits...

Yep, I have no idea what's going on here. It's just this PR, right? Probably best to reach out to codecov and see if this is a bug in codecov....

Can you rebase to resolve the merge conflict? Still no idea why codecov has been buggy lately. I'll force merge if I need to.

The drop in coverage here is legit, I was able to reproduce it locally: ```console $ pytest --cov=torchgeo/trainers --cov-report=term-missing tests/trainers/ =============================================================================================== test session starts ================================================================================================ platform darwin -- Python 3.9.13,...

There's another line too.

There's a reason for the try-except. Lightning is very much dynamically typed, and makes no guarantees that any of these attributes will exist: * `self.trainer.datamodule` * `datamodule.plot` * `self.logger.experiment` That's...

@isaaccorley does this need a predict step?

This was also reported in #31939. It seems to be due to distro-specific patches to the system Python. Only current workaround is to use Spack-installed Python instead of system Python.

That would break a lot of external packages. For example, imagine you have Python 3.7 in `/usr/bin/python` and Python 3.9 in `/usr/local/bin/python`. If you use: ```yaml - spec: python prefix:...