kickstart icon indicating copy to clipboard operation
kickstart copied to clipboard

NavBar Responsive Collapse items not shown in Chrome and Firefox

Open panosdim opened this issue 9 years ago • 7 comments

The example code

<div class="navbar navbar-collapse" data-ks-navbar>
  <nav>
    <ul>
      <!-- This will be the title and
           the responsive collapse button -->
      <li class="navbar-title">
        <h1>Acme Corp</h1>
        <button role="button">=</button>
      </li>

      <!-- These are the collapsed navigation
           items. -->

      <li>
        <a href="/products/">Products</a>
      </li>
      <li>
        <a href="/blog/">Blog</a>
      </li>
    </ul>
  </nav>
<div>

Is not shown the collapse button in firefox and chrome when i enable a tablet or mobile layout in Developer Tools.

panosdim avatar Sep 15 '16 14:09 panosdim

very similar problem here. i called k$.nav('.navbar'); yet the problem stays.

asif-mahmud avatar Dec 22 '16 16:12 asif-mahmud

solved with a new problem. my navbar block -

 <div class="navbar" data-ks-navbar>
    <nav>
        <ul>
              <li class="navbar-title"><button role="button>=</button></li>
              <li><a href="#">HOME</a></li>
        </ul>
   </nav>
</div>

loaded kickstart.min.js and after that -

<script>
document.addEventListener('DOMContentLoaded', function () {
    $k.nav('.navbar');
} );
</script>

not k$ as in the documentation. now it's working but getting a console error -

Uncaught ReferenceError: $k is not defined

asif-mahmud avatar Dec 22 '16 16:12 asif-mahmud

Ah. Must be a typo. You'll never need to use $k On Thu, Dec 22, 2016 at 10:39 AM Asif Mahmud Shimon < [email protected]> wrote:

ok solved with a new problem :-) my navbar structure - `

  • =
  • HOME
  • loadedkickstart.min.jsand then - `

    i had to use $k instead of k$ as in the documentation.

    now it's working but in console getting Uncaught ReferenceError: $k is not defined error.

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adamjgrant/kickstart/issues/193#issuecomment-268838253, or mute the thread https://github.com/notifications/unsubscribe-auth/AATj7qCBMx50y91cVCWWJSljcQjoa8LUks5rKqeegaJpZM4J96Ax .

    -- Adam Grant

    adamjgrant avatar Dec 22 '16 18:12 adamjgrant

    So what was the problem you were having with using k$? On my phone out in the country so it's hard for me to check. On Thu, Dec 22, 2016 at 12:30 PM Adam Grant [email protected] wrote:

    Ah. Must be a typo. You'll never need to use $k On Thu, Dec 22, 2016 at 10:39 AM Asif Mahmud Shimon < [email protected]> wrote:

    ok solved with a new problem :-) my navbar structure - `

    • =
  • HOME
  • loadedkickstart.min.jsand then - `

    i had to use $k instead of k$ as in the documentation.

    now it's working but in console getting Uncaught ReferenceError: $k is not defined error.

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/adamjgrant/kickstart/issues/193#issuecomment-268838253, or mute the thread https://github.com/notifications/unsubscribe-auth/AATj7qCBMx50y91cVCWWJSljcQjoa8LUks5rKqeegaJpZM4J96Ax .

    -- Adam Grant

    -- Adam Grant

    adamjgrant avatar Dec 22 '16 18:12 adamjgrant

    i tried 3 styles -

    $k.$('.navbar').navbar(); //works but gives a console error !
    
    k$.nav('.navbar'); // doesn't work. clicking the hamburger doesn't drop down the links
    
    k$.$('.navbar').navbar(); // works
    

    asif-mahmud avatar Dec 22 '16 21:12 asif-mahmud

    BTW i have using kickstart-node version 3.0.75

    asif-mahmud avatar Dec 22 '16 21:12 asif-mahmud

    Okay, it's working just fine. checked in chrome, firefox.

    you were right, no need to use js for it.

    great framework. using with sass and gulp makes it really small. why didnt i find it earlier !

    asif-mahmud avatar Dec 22 '16 22:12 asif-mahmud