Adam Hathcock

Results 331 comments of Adam Hathcock

If it's in the metadata, then it's something that's just been overlooked for whatever reason. Should be a relatively quick thing to do.

Zip has the same issue with streamed files where you don't know the size before compression. We should be able to implement this size on XZ when using Archive strategy...

This is how the current GZipStream works because it's trying to validate the data. An option to skip this could possibly be added. If you don't want to read more,...

I accept pull requests

It probably shoud be removed and always use the long codepath. I guess I removed the setting/testing of it at some point accidently. It was added alongside Rar5 support it...

This is really about non-compressed internal archives which is same as https://github.com/adamhathcock/sharpcompress/issues/86 I believe

Thanks for the repro steps. I'll look at this soon. Not sure why encoding has been difficult for me in this project. I assume UTF8 doesn't work?

There was probably some adjustment of a bug or logic. Though, I'm interested in your second point wondering how valid a zip file it is. Maybe it's allowed by spec...

Not sure how these pass locally for you as some of the code looks at the `CanSeek` flags to do different things. That's why the test is failing because `ReadOnlySubStream`...