Adam Fraser

Results 324 comments of Adam Fraser

@johnspade Okay let's take a look at that.

Don't you actual want a dispatcher for `F`, the effect type you are converting from?

Yeah I would actually think the `toManaged` variant would be more common where you had like a `Resource[CIO, A]` and wanted to convert it into a `ZManaged`. And that is...

Yes we definitely want to support both styles. If you are working with `Dispatcher` and your application isn't ultimately a Cats Effect application then you are going to have to...

Could it be related to https://github.com/zio/zio/issues/3073?

@vigoo Yes. I was trying to avoid having separate implementations but agree it may make sense here.

The main issue here is we have a couple of variants of lookup functions, returning a `ZIO[R, E, A]`, a `ZIO[R, E, Chunk[A]` and potentially a `ZManaged[R, E, A]` there...

In general we shouldn't be adding platform specific tests. We should be presenting a consistent cross platform interface and our tests should pass on all platforms. Definitely agree about more...