Paladin
Paladin copied to clipboard
Current source checkout fails with a parse error on gcc2
This is with: https://github.com/adamfowleruk/Paladin/blob/develop/Paladin/PreviewFeatures/CommandOutputHandler.h#L29
https://paste.ubuntu.com/p/YPfQTXsdtp/
EDIR Stripping "override" on that line fixes the build (but I'm pretty sure it's not the correct sollution ;)
- virtual void MessageReceived(BMessage* msg) override;
+ virtual void MessageReceived(BMessage* msg);
On another not "-lgcov" is gcc8 only afaik: https://github.com/adamfowleruk/Paladin/blob/44887d1fea2a3b3cecf0878dbc531ff09b850630/Tests/compile.sh#L11 Tests are OK on gcc2 without -lgcov there also
Fixed for Haikuports PR. Patch provided there.
Thanks for this. I'll ensure that my build testing uses x86 in the pipeline in future. Should catch things like this.