Paladin icon indicating copy to clipboard operation
Paladin copied to clipboard

Current source checkout fails with a parse error on gcc2

Open Begasus opened this issue 4 years ago • 3 comments

This is with: https://github.com/adamfowleruk/Paladin/blob/develop/Paladin/PreviewFeatures/CommandOutputHandler.h#L29

https://paste.ubuntu.com/p/YPfQTXsdtp/

EDIR Stripping "override" on that line fixes the build (but I'm pretty sure it's not the correct sollution ;)

-	virtual void							MessageReceived(BMessage* msg) override;
+	virtual void							MessageReceived(BMessage* msg);

Begasus avatar Jul 22 '20 07:07 Begasus

On another not "-lgcov" is gcc8 only afaik: https://github.com/adamfowleruk/Paladin/blob/44887d1fea2a3b3cecf0878dbc531ff09b850630/Tests/compile.sh#L11 Tests are OK on gcc2 without -lgcov there also

Begasus avatar Jul 22 '20 08:07 Begasus

Fixed for Haikuports PR. Patch provided there.

kenmays avatar Jul 24 '20 17:07 kenmays

Thanks for this. I'll ensure that my build testing uses x86 in the pipeline in future. Should catch things like this.

adamfowleruk avatar Sep 19 '20 12:09 adamfowleruk