Adam Dougal comments

Results 45 comments of


                                            Adam Dougal

Allow authentication using RBAC instead of API Keys

@pamelafox Those have now been added

Allow authentication using RBAC instead of API Keys

Heya, thanks for your review comments! I've made some changes. Please note, I've yet to test them out. I'll update on here when I have.

Allow authentication using RBAC instead of API Keys

I've now tested this deployed to Azure, as well as running locally. I did not have to create any additional role assignments to get this to work locally.

Allow authentication using RBAC instead of API Keys

> > I've now tested this deployed to Azure, as well as running locally. I did not have to create any additional role assignments to get this to work locally....

Allow authentication using RBAC instead of API Keys

Heya, I believe this is ready for re-review. Thanks

Allow authentication using RBAC instead of API Keys

Heya @jongio, thanks for the further comments. I have addressed them and rebased from main. Unfortunately, I have no information as to why this is not in the azure samples...

Allow authentication using RBAC instead of API Keys

Heya, can this be merged? Thanks

Allow authentication using RBAC instead of API Keys

Heya! Is this ready to be merged now? Thanks

Allow authentication using RBAC instead of API Keys

@sarah-widder Is this still required? It looks like similar changes have been made in https://github.com/microsoft/sample-app-aoai-chatGPT/pull/460?

Allow authentication using RBAC instead of API Keys

I guess it's just the infra side of things that's still required?