Adam Shannon

Results 394 comments of Adam Shannon

Links https://www.gov.uk/government/publications/the-uk-sanctions-list https://www.gov.uk/government/publications/financial-sanctions-consolidated-list-of-targets/consolidated-list-of-targets https://github.com/search?o=desc&q=language%3Ago+xpath&s=stars&type=Repositories https://pkg.go.dev/encoding/csv

DOB is not currently supported in search, but would be great to add. If you (or someone following this repo) wants to PR that feature I'd happily review it for...

It might be easy enough to include a dropdown next to "Search" that allows you to switch between lists. The inputs and results areas might need to be changed to...

fyi, NYSIIS would probably be used instead of soundex (see: https://github.com/moov-io/ofac/issues/150)

> Those `wget` calls are running in regular anonymous mode, where they are subject to rate-limiting rules. If we change these to use the GITHUB_TOKEN, GitHub will see them as...

Previously we sent `WEB` files when that SEC code was specified along with `PaymentInformation` which was passed directly into the ACH file itself. An initial implementation could be to have...

I can see us offering a file config where we can specify targets to notify. The payload would be an ACH file's [JSON representation](https://github.com/moov-io/ach/blob/master/test/testdata/ppd-valid.json). PayGate would retry sending this until...

Would an admin endpoint for registering a webhook be useful? I can see us supporting something like this: ``` $ curl -X POST http://paygate:9092/webhooks { "target": "", "authToken": "", "insecure":...

Yep. I added a `filters` object where we can limit what the webhook fires on, so `eventTypes`, `transferIDs`, etc.. We can extend those filters going forward.

We should add some prometheus metrics around returned entries including their code. Right now we've just got metrics around the returned files, which is very different from these metrics/alerts.