django-hordak
django-hordak copied to clipboard
adamcharnock
chore: Changing Appconfig default_auto_field to BigAutoField
changing the id field from AutoField to BigAutoField to support wide range of numeric id combinations
@Lekhanshlkr Generally looks good, thank you very much. Would you please look at the failed tests?
@PetrDlouhy I've applied black formatting to my code. The other issue was related to failing of the mariadb core in the ci.yml. Could you please look into it?
@Lekhanshlkr I fixed the mariadb problem in master branch. Could you please rebase?
Codecov Report
Patch and project coverage have no change.
Comparison is base (
79703ea) 92.97% compared to head (2cae7eb) 92.97%. Report is 1 commits behind head on master.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@ Coverage Diff @@
## master #99 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 59 59
Lines 3829 3829
Branches 250 250
=======================================
Hits 3560 3560
Misses 224 224
Partials 45 45
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@PetrDlouhy There are still tests failing with MariaDB. Could you please look into it?
@Lekhanshlkr I am not sure why this happens. The master branch now passes all tests, so it shouldn't be the issue.
The only thing I can think of is, that maybe the parent_id fields has stayed in the 32-bit format (weren't migrated) and that is causing the problems.
Thank you for this @Lekhanshlkr! I recreated these changes locally and all the checks seemed to pass happily. I guess something got resolved since August. I'll close this PR, but your proposed changes have now been merged in #112.
