django-mysql icon indicating copy to clipboard operation
django-mysql copied to clipboard

Published 20 hours ago • verified publisher icon adamchainz

Checks that use is_mariadb should check that django_mysql is an installed app first

Open adamchainz opened this issue 9 years ago • 2 comments

Summary: @shanukus98765 reported an issue in #281 that was really caused by Django-MySQL not being in INSTALLED_APPS, we should make the checks that depend on is_mariadb first check if Django-MySQL is installed before trying to use this monkey-patched property.

adamchainz avatar Sep 20 '16 09:09 adamchainz

Another idea is to stop monkey patching is_mariadb and instead just provide a function that takes the connection

adamchainz avatar Dec 10 '16 12:12 adamchainz

#362 removed the monkey patch which has simplified things somewhat, but really we should be testing if the module is in INSTALLED_APPS too in case of future compatibility conflicts.

adamchainz avatar May 28 '17 11:05 adamchainz