Adam Johnson comments

Results 601 comments of


                                            Adam Johnson

Feature Request: No Useless List Unpack-Repack

Unpacking is faster, presumably because it doesn't need to look up the name `list`. So, let's leave this. ```ipython In [1]: items = list(range(10)) In [2]: %timeit list(items) 52.1 ns...

test_version: flake8 plugins not normalized

I don’t generally support running the tests outside of the `tox` setup within the repo. I would consider merging a fix if you could explain why the name is changed....

Feature Request: (New Rule) Detect useless generator pattern

This seems like a legitimate rule to add. Would you like to make a PR?

Add closure variables into global scope

I think you're off to a good start, but this is failing the tests. Please try running the tests locally with e.g. `tox -e py311`. Also, add some tests covering...

Add closure variables into global scope

> Also I added new test with my code example. I don't see this test? Or a changelog note.

fix(templates): Remove use of deprecated filter

Thank you. This LGTM. Hopefully, a maintainer will be by soon.

Checking all files in git index

You can use `git ls-files | xargs typos` - see [my post](https://adamj.eu/tech/2022/03/09/how-to-run-a-command-on-many-files-in-your-git-repository/).

Checking all files in git index

Try `git ls-files -z | xargs -0 ls -l`

Checking all files in git index

I've now updated my post to use null byte separators.

Port unittests.mock package

Unnecessary as this exists: https://pypi.python.org/pypi/backports.unittest_mock/1.0