react-oauth-flow icon indicating copy to clipboard operation
react-oauth-flow copied to clipboard

Going from 1.1.1 -> 1.1.2 I end up in a death loop

Open elsigh opened this issue 6 years ago • 3 comments

I use this in a nextjs app, and something / somehow goes haywire if I upgrade to 1.1.2. If I downgrade to 1.1.1 everything is fine.

image

Here's my code using Sender:

      <Sender
          state={{ to: "/" }}
          render={({ url }) => (
            <div style={{ display: "flex", alignItems: "center" }}>
              <img
                src="/static/notes.png"
                height={20}
                width={20}
                alt=""
                style={{
                  marginRight: 5,
                }}
              />
              <a href={url}>Sign in</a>
              <div style={{ margin: "0 5px" }}>|</div>
              <SignInAsGuest />
            </div>
          )}
        />

elsigh avatar Sep 12 '18 15:09 elsigh

Also, worth noting, I created Sender there with this code:

const { Sender, Receiver } = createOauthFlow({
  authorizeUrl: "https://www.dropbox.com/oauth2/authorize",
  tokenUrl: "https://api.dropbox.com/oauth2/token",
  clientId: DROPBOX_APP_KEY,
  clientSecret: DROPBOX_APP_SECRET,
  redirectUri: IS_DEV
    ? "http://localhost:3000/authreceiver"
    : "https://chartcomposer.com/authreceiver",
});

elsigh avatar Sep 12 '18 16:09 elsigh

Hi, sorry but I haven't had the time to look into this. I'll see if I can take a look at it later this week. Have you tried to look into it yourself, maybe identified what might be the problem?

adambrgmn avatar Sep 17 '18 06:09 adambrgmn

I've not yet looked, I was hoping something in terms of your changes between the two point releases might strike you as obvious, but I can experiment more. For now I'm just pinned to the prior version so it's not a major deal.

elsigh avatar Sep 17 '18 17:09 elsigh