learnxinyminutes-docs icon indicating copy to clipboard operation
learnxinyminutes-docs copied to clipboard

Update fortran90.html.markdown

Open Ily83 opened this issue 1 year ago • 4 comments

added DO CONCURRENT

  • [x] I solemnly swear that this is all original content of which I am the original author
  • [x] Pull request title is prepended with [language/lang-code] (example [python/fr-fr] or [java/en])
  • [x] Pull request touches only one file (or a set of logically related files with similar changes made)
  • [x] Content changes are aimed at intermediate to experienced programmers (this is a poor format for explaining fundamental programming concepts)
  • [x] If you've changed any part of the YAML Frontmatter, make sure it is formatted according to CONTRIBUTING.md
    • [x] Yes, I have double-checked quotes and field names!

Ily83 avatar Nov 04 '22 00:11 Ily83

Thank you for the addition of this function introduced more recently to Fortran (in Fortran's time scale). For consistency of the format of presentation, may you please edit the comments into two-line comments, i.e., to substitute a)

! ISO Standard Fortran 2008 introduced the DO CONCURRENT construct to allow you to express loop-level parallelism

by

! ISO Standard Fortran 2008 introduced the DO CONCURRENT construct to allow you
! to express loop-level parallelism.

and b)

! Only calls to pure functions are allowed inside the loop and we can declare multiple indices:

by

! Only calls to pure functions are allowed inside the loop and we can declare
! multiple indices:

This is one of the convened rules to ease the eventual display as web page applying a one-for-all languages style sheet (though not always working for everyone's setup, e.g. example and example). Independent of the project, this restrain on the code blocks simultaneously eases to read your contributions here on GitHub's issue reports (no need for a horizontal scroll bar) and inspections of git's difference views in a terminal, too.

nbehrnd avatar Nov 04 '22 08:11 nbehrnd

Can I add more stuff here or should I need to do another pull request?

Ily83 avatar Nov 21 '22 19:11 Ily83

Addition of @robochat (the initiator of the Fortran summary), addition of @mribeirodantas (one of those with the key to merge .and. more frequently seen).

nbehrnd avatar Nov 22 '22 09:11 nbehrnd

@Ily83 If the additional edit belongs to do concurrent, I suggest to amend the current PR. If it is independent, I would suggest a separate PR (as in atomic changes / one additional feature described at a time). If the edit requires do concurrent to be already described, I would file a PR after the current PR has been merged.

nbehrnd avatar Nov 22 '22 09:11 nbehrnd