ngQuickDate icon indicating copy to clipboard operation
ngQuickDate copied to clipboard

use ng-click instead of ng-mousedown for touch devices

Open GraemeRFalkner opened this issue 9 years ago • 6 comments

ngQuickDate does not work on mobile devices with the current version of Angular 1.x. The reason is that Angular does not emit an ng-mousedown when the user taps on a calendar entry. Two new options have been added, both default to false to prevent breaking changes on legacy installations. isTouchDevice: Allows ngQuickDate to be manually configured to use ng-click instead of ng-mousedown detectTouchDevices: Detects if touch is available and uses ng-click or ng-mousedown as appropriate. Updated version number to 1.3.4

GraemeRFalkner avatar Oct 03 '15 07:10 GraemeRFalkner

@GraemeRFalkner How do I reproduce this not working? It seems to work on my iPhone without using either of the new options.

adamalbrecht avatar Oct 07 '15 13:10 adamalbrecht

What version of Angular are you using? We found that ngQuickDate worked fine with Angular 1.0 but not with Angular 1.3.4

GraemeRFalkner avatar Oct 11 '15 08:10 GraemeRFalkner

I still can't reproduce it (on the demo page) with either Angular 1.3.4 or 1.4.7 (the latest) on my iPhone 6 with iOS 9.

It's very possible that it's breaking on other mobile platforms (Android or older versions of iOS) or by using a different set of circumstances from the demo page.

adamalbrecht avatar Oct 15 '15 14:10 adamalbrecht

Ok Thanks, I will investigate further to try to figure out why it doesn't work for us.

GraemeRFalkner avatar Oct 15 '15 19:10 GraemeRFalkner

@GraemeRFalkner Any updates on this ? Free to help out if its needed!

novarac23 avatar Jan 06 '16 19:01 novarac23

@GraemeRFalkner Hey mate! Need any help with that investigation ? I am willing to help out if needed :)

novarac23 avatar Feb 05 '16 12:02 novarac23