markdown-here icon indicating copy to clipboard operation
markdown-here copied to clipboard

Updated highlightjs to v9.0.9

Open daemedeor opened this issue 8 years ago • 10 comments

Updated the highlight.js library to the v9.0.9 version that allows for more language support like Julia. Also updated the tests as some of the library changes the markup a little, namely with a wrapper. I tested with Chrome only but I don't think that it should have a major effect on the other parts of the library. This is in response to another issue that was brought up a bit ago and since it was quick to do: #402

daemedeor avatar Jan 08 '17 04:01 daemedeor

Okay, now it's updated to use the non minified version

daemedeor avatar Jan 08 '17 09:01 daemedeor

See #402

ickc avatar Jan 09 '17 05:01 ickc

@ickc this is to solve the request to update it, it's not a issue but it's a PR

daemedeor avatar Jan 09 '17 08:01 daemedeor

I mean to cross reference it to #402, since your original comment has a typo that reference to #403. I was just lazy so I didn't write this (and I see you already corrected your typo)

ickc avatar Jan 09 '17 10:01 ickc

Fixes #408

jrappen avatar May 30 '17 09:05 jrappen

Fixes #414

jrappen avatar May 30 '17 09:05 jrappen

@adam-p Attached is v9.12.0 with the styles.json updated accordingly.

highlightjs-v9-12-0.zip

jrappen avatar Oct 27 '17 07:10 jrappen

@adam-p Would you prefer an update to this pr or a new pr instead? This issue is a longstanding one and your extension relies upon highlight.js for syntax highlighting. It would be great to have the extension updated with a newer version of highlight.js which supports more languages.

jrappen avatar Nov 10 '17 08:11 jrappen

Kotlin seems not working in the current version, checked https://github.com/adam-p/markdown-here/blob/master/src/common/highlightjs/highlight.js and cannot find registerLanguage for Kotlin also. Is there some else needed to do to support Kotlin?

shenguojun avatar Dec 15 '18 14:12 shenguojun

Finally I have solved these problem. For people need kotlin heighlight & weixin open platform style support can use the code here https://github.com/shenguojun/markdown-here

shenguojun avatar Dec 16 '18 04:12 shenguojun