adam-james

Results 12 issues of adam-james

Epic: #24759 Fixes: #3735 This PR fixes areas where static-viz does not apply column formatting. It also has some render test utils that can be used to run and test...

This is a Clojure-side migration (WIP/open for discussion) that converts any regular table Cards to pivot-table cards if: - the card's `:display` is `:table` - `:visualization_settings` has `:table.pivot true` I'll...

Many of the body-tests just assert that an image was actually rendered. This isn't particularly powerful, because it doesn't say anything about the actual contents of the render. In fact,...

Per [this tweet](https://twitter.com/plexus/status/1478024531151364101?s=20), I think it's a good idea to add docstrings to each namespace.

When importing SVG files, there may be valid SVG that stores dimensions as strings. The transform functions all expect numbers and so if a dimension attribute stores the value in...

Fixes: #38022 ### Before Before some changes to the QP, I think probably some mlv2 changes, particularly those affecting metadata calculation, we would return a `:semantic_type` on aggregations. Here's a...

backport
.Team/DashViz

Fixes: #38307 Changing the drill query to lock the Question's display solves the issue where the display from the card is not used when doing a zoom drill through action...

backport
.Team/DashViz

Fixes #41635 This PR adds the following endpoint to the preview-embed api: `GET /api/preview_embed/dashboard/:token/params/:param-key/values` Refactor the embedding api namespace to allow a bit of reuse between the embedding api and...

backport
.Team/DashViz

Fixes: #41669 Since PR #39120 , the slugify util was used to make card names URL safe. This was done for turning things like spaces into underscores. But, it unfortunately...

backport
.Team/DashViz

CSV exports of Pivot tables should now look like the table does in the App. ![image](https://github.com/metabase/metabase/assets/21064735/0484d51e-1754-480c-9897-7d1361ed7a9b) This is done by post-processing the rows generated by the qp.pivot namespace. The postprocessing...

backport
.Team/DashViz