FifteenStep icon indicating copy to clipboard operation
FifteenStep copied to clipboard

Moved to actions, did doxygen

Open evaherrada opened this issue 4 years ago • 10 comments

evaherrada avatar Jun 24 '20 20:06 evaherrada

@ladyada Seems like the examples require some libraries like BLE and NeoPixel. Should I add those to library.properties or is there a better way to do it when it's just the examples that need it?

evaherrada avatar Jun 24 '20 20:06 evaherrada

@ladyada This seems to be missing malloc.h which I think might be part of the MemoryFree library, which I think is a default library on some boards. I'm not sure which ones, but I guess the ones tested might not be those.

Also, I'm not quite sure if anything is not supposed to be run with specific boards. I did see a comment in neo_mpr121 (https://github.com/adafruit/FifteenStep/blob/actionci/examples/neo_mpr121/neo_mpr121.ino#L294-L297) that seems to say it's only supposed to run on the leonardo and micro, although I could be misinterpreting that.

evaherrada avatar Jun 25 '20 16:06 evaherrada

you should be able to add an #include <stdlib.h> to get it included. its a built in C function

ladyada avatar Jun 25 '20 16:06 ladyada

@ladyada I'm not really sure if this was the right thing to do, but I did make a pr on zerodma to do that. https://github.com/adafruit/Adafruit_ZeroDMA/pull/22

evaherrada avatar Jun 25 '20 16:06 evaherrada

Looks like each of the examples is specific to one type of board, check comments at the top of each .ino for hints.

Saw some mentions of MIDIUSB in the Actions build errors. That library only works on USB-native devices…so like, older boards with a serial converter chip won’t work. Probably Leonardo & Zero only, I’m guessing.

PaintYourDragon avatar Jun 26 '20 00:06 PaintYourDragon

@PaintYourDragon So the leonardo has a usb to serial converter if I'm not mistaken, but neo_mpr121 says:

// A MIDI sequencer example using two chained NeoPixel sticks, a MPR121
// capacitive touch breakout, and an Arduino Micro (or Leonardo).

So it shouldn't work since midusb is used, but it looks like it was intended to work and at some point did, which seems odd

evaherrada avatar Jun 26 '20 15:06 evaherrada

Leonardo uses a USB-native AVR, no serial converter. It was a weird animal.

PaintYourDragon avatar Jun 28 '20 00:06 PaintYourDragon

Yeah, I'm not quite sure what to do about this one.

evaherrada avatar Jun 29 '20 13:06 evaherrada

Looks like neo_mpr121.ino might be using a deprecated syntax for MIDI calls…try global search-and-replace: MIDIEventPacket_t change to midiEventPacket_t MIDIUSB change to MidiUSB

PaintYourDragon avatar Jun 29 '20 15:06 PaintYourDragon

@PaintYourDragon Do you mind taking another look at this? It does appear to be passing

evaherrada avatar Oct 06 '20 17:10 evaherrada