Adafruit_Wippersnapper_Arduino icon indicating copy to clipboard operation
Adafruit_Wippersnapper_Arduino copied to clipboard
verified publisher icon adafruit

Switch Analog Voltage on esp32 to use analogReadMilliVolts

Open tyeth opened this issue 1 year ago • 1 comments

Having issues with the C6 (set aVref to 1.1v and got 0.48v from 3v3 signal). Just wanted to look into attenuation and the aVref, but saw that analogReadMilliVolts returned the calibrated millivolts, rather than the raw adc value which is uncalibrated.

This PR now switches both periodic and on_change to use the same functions, along with using analogReadMilliVolts for ESP32 based boards.

tyeth avatar Aug 20 '24 21:08 tyeth

note to self, retest this theory: https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/80b746199f0aa75e3b5e2c400f94abdfb26074ee/src/components/analogIO/Wippersnapper_AnalogIO.cpp#L90

tyeth avatar Sep 24 '24 17:09 tyeth

This is superseded by #635

tyeth avatar Oct 15 '24 16:10 tyeth