Adafruit_Wippersnapper_Arduino
Adafruit_Wippersnapper_Arduino copied to clipboard
adafruit
Regenerate displayconfig.json if erroneous
It's possible for the display config file to be corrupt, at which point the funhouse fails to continue. It's a standard file we generate so this commit regenerates the file if erroneous
@tyeth Can we hold on to this PR until we merge and release what's required for NO-OTA?
We definitely can, although testing the noota was when I encountered the issue. The partition was corrupt but valid, and displayconfig was corrupt so board stalled (no visual output too obviously)
On Mon, 22 Apr 2024, 16:43 Brent Rubell, @.***> wrote:
@tyeth https://github.com/tyeth Can we hold on to this PR until we merge and release what's required for NO-OTA?
— Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/pull/575#issuecomment-2069952576, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTBZ43D5AORF5WTZFJIXZDY6UV3FAVCNFSM6AAAAABGTAH7BSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZHE2TENJXGY . You are receiving this because you were mentioned.Message ID: @.***>
Ah yes, also when secrets exists but is corrupt (usually 0bytes).
I've been seeing some weird behaviour regarding first boot after installation (second boot gives more stable filesystem), but not pinned down anything definitive.
Leaving this one open until file system corruption issue is resolved hopefully this week. It could go in as is, but there will be movement in same code areas as we try to avoid unnecessary file writes at boot.