Adafruit_VS1053_Library icon indicating copy to clipboard operation
Adafruit_VS1053_Library copied to clipboard

Please fix sdfat

Open BiatuAutMiahn opened this issue 2 years ago • 4 comments

When using with Adafruit's sdfat library, you get errors and it will refuse to compile.

BiatuAutMiahn avatar May 01 '23 12:05 BiatuAutMiahn

Meanwhile there is no way to fix all those sdfat problems for all boards: sdfat ist the most incompatible library in the whole Arduino land, caused by "to do one's own thing", so we have: old sdfat version by greiman new sdfat version by greiman teensy one ESP8266 one Adafruit one RP2040 one (mostly ESP8266 one, but not really...) ...and many more.

madias123 avatar Jun 09 '23 08:06 madias123

Why not target greiman's new repo, or adafruit's. And leave sdfat compatibility for different boards upstream?

Currently I use greiman's...haphazardly.

BiatuAutMiahn avatar Jun 11 '23 17:06 BiatuAutMiahn

Why not target greiman's new repo, or adafruit's. And leave sdfat compatibility for different boards upstream?

Currently I use greiman's...haphazardly.

It's a little bit complicated, because I'm converting an old TAG-MP3-Player-project of mine (STM32duino (Rogers Core), SDFat V1(!) and libraries that I modified in the past using SDfat (like VS1503). Meanwhile, I converted the project step by step as a whole new project, caused by too old libraries used in the original code and too much hacks/tricks and workaround especially for the STM32 (low level). Meanwhile I can use my major IO-Code (reading/writing SD Card, sorting dirs and files, reading outMP3-tags) with just the simple #include <SD.h> because this in in the RP2040 core just a wrapper for sdfat V2! So I'm fine with that.

madias123 avatar Jun 12 '23 08:06 madias123

Gotcha

BiatuAutMiahn avatar Jun 13 '23 00:06 BiatuAutMiahn