Adafruit_VS1053_Library icon indicating copy to clipboard operation
Adafruit_VS1053_Library copied to clipboard

Published 20 hours ago • verified publisher icon adafruit

Update record_ogg.ino

Open sningo opened this issue 2 years ago • 3 comments

Missing update of addr. Perhaps never noticed as it only addresses the last bytes to be written to the record

sningo avatar Apr 10 '23 20:04 sningo

@ladyada can you have someone look at these pull requests? Many of them are years old.

johnwargo avatar Nov 26 '23 13:11 johnwargo

@sningo can you describe the issue that this fixes? What happens today and what is different with this fix?

johnwargo avatar Nov 28 '23 22:11 johnwargo

@johnwargo today: If more than one sample is available (line 147), then only the last collected word is being written/ earlier ones being overwritten, making the audio record incomplete.

with the fix: Code snipped will probably do what it was initially intending (otherwise I cannot see any meaning in the declaration of the variable addr). All available words are written to the record_buffer, resulting in a complete audio record

sningo avatar Nov 29 '23 05:11 sningo