Adafruit_VS1053_Library icon indicating copy to clipboard operation
Adafruit_VS1053_Library copied to clipboard

Published 20 hours ago • verified publisher icon adafruit

Cleanup startPlayingFile

Open TheNitek opened this issue 7 years ago • 1 comments

startPlayingFile seems overly complicated right now, so I'd suggest to to clean it up a bit. While filling the buffer initially sounds nice, it doesn't seem to bring any real benefit (you have to start refilling right away anyway). Right now it's very confusing:

  • feedBuffer() is called within a loop that is happening within feedBuffer_noLock anyway
  • interrupts() is called afterwards even though interrupts are already enabled by feedBuffer()

In my opinion removing the complexity outweighs the "need" to initially fill the buffer.

TheNitek avatar Jan 23 '18 18:01 TheNitek

@TheNitek this PR is 5 years old now and nothing's happened with it. Close it?

johnwargo avatar Nov 28 '23 22:11 johnwargo