Adafruit_Learning_System_Guides
Adafruit_Learning_System_Guides copied to clipboard
adafruit
Update code.py
Noticed that midnight was not handled properly for cases like "Five to Midnight" or "Twenty after Midnight". Was seeing noon instead of midnight.
@elmwoodelec Thank you for submitting a Pull Request. Your code is currently not passing the linter due to an Undefined variable named MIDIGHT (Output: https://travis-ci.com/adafruit/Adafruit_Learning_System_Guides/builds/120074471#L1171).
Once you fix that up, re-commit and we'll take a look!
@elmwoodelec This branch is out-of-date with master, you'll need to merge the latest changes from master into it.
@TheKitty Could you take a look at this PR and review?
Let me know when ready and I'll check
On Thu, Aug 8, 2019 at 9:22 AM Brent Rubell [email protected] wrote:
@elmwoodelec https://github.com/elmwoodelec This branch is out-of-date with master, you'll need to merge the latest changes from master into it.
@TheKitty https://github.com/TheKitty Could you take a look at this PR and review?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/adafruit/Adafruit_Learning_System_Guides/pull/775?email_source=notifications&email_token=AAOSY4GAEG6MYIGMX5Z6B2LQDQMZNA5CNFSM4IF4TAB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD33S3VA#issuecomment-519515604, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOSY4FCZZET26G5HTCOI6LQDQMZNANCNFSM4IF4TABQ .
