Adafruit_ImageReader icon indicating copy to clipboard operation
Adafruit_ImageReader copied to clipboard

Not necessarily bugs, but recommendations…

Open PaintYourDragon opened this issue 4 years ago • 7 comments

First: would suggest renaming one or two of the examples, specifically EInkFeatherWing and/or EInkGray29BmpButtonDemo. The grayscale FeatherWing is labeled “2.9" E-Ink FeatherWing” on the back, and running the EInkFeatherWing sketch here almost sorta works, just enough that some guy who’s not the sharpest stick might’ve spent an entire day trying to figure out what’s wrong with his BMP, his Arduino code and/or delved deep into the ImageReader source looking for the “bug” when it was really just that he needed to use the other example that, while it does have “Gray” in the name, “Gray” doesn’t appear on the FeatherWing and “FeatherWing” does not appear in the example name. He doesn’t get out often.

Second: I don’t know if this is a bug/typo or was an intentional choice done for perceptual or legibility reasons, but noticed while I was in the code that on grayscale displays, brightness levels below 0x60 (rather than 0x40) are assigned black. The image I was testing with just happened to be a gray ramp, and with this threshold level the range of dark grays get “the squeeze.” Can’t load the original BMP here because Github, so here’s a JPG substitute:

gray-ramp

And how it appears on the ’Wing:

gray-on-wing

But again, if that’s intentional…maybe it’s to make most line art look right or something…please disregard.

PaintYourDragon avatar Oct 28 '20 16:10 PaintYourDragon