Adafruit_CircuitPython_AdafruitIO icon indicating copy to clipboard operation
Adafruit_CircuitPython_AdafruitIO copied to clipboard

send_batch_data requires class instances when it should just require accept a list or dict

Open evaherrada opened this issue 3 years ago • 3 comments

https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO/blob/main/adafruit_io/adafruit_io.py#L607

The _asdict method needs to be run on an instance of a class to get the class attributes. It would be easier for most users to just send a list or dict.

evaherrada avatar Aug 24 '22 22:08 evaherrada

cc @brentru

evaherrada avatar Aug 24 '22 22:08 evaherrada

@evaherrada Do you want to work on this issue next week? Tag me when there's a PR ready for review

brentru avatar Sep 02 '22 20:09 brentru

I’m available to help however I can, at the very least for testing.

rbrian avatar Sep 03 '22 17:09 rbrian

Closing this after merging #125 and releasing v5.9.0

tyeth avatar Jul 19 '24 11:07 tyeth