Adafruit-WS2801-Library icon indicating copy to clipboard operation
Adafruit-WS2801-Library copied to clipboard

make matrix mode better defined, pull in Color/Wheel helper functions

Open TonyLHansen opened this issue 7 years ago • 0 comments

Thank you for creating a pull request to contribute to Adafruit's GitHub code! Before you open the request please review the following guidelines and tips to help it be more easily integrated:

  • Describe the scope of your change--i.e. what the change does and what parts of the code were modified. This will help us understand any risks of integrating the code.

Make matrix mode better defined by defining the strand length to be equivalentl to a 1xN matrix. Allow the matrix sizes to be updated. Allow switching back and forth between treating the pixels as a single strand OR as a matrix. Pull in the Color and Wheel helper functions from the examples as stati functions. In the example code, take advantage of helper functions now being in the Adafruit_WS2801 library.

  • Describe any known limitations with your change. For example if the change doesn't apply to a supported platform of the library please mention it.

None: fully generic changes

  • Please run any tests or examples that can exercise your modified code. We strive to not break users of the code and running tests/examples helps with this process.

I am running code against this changed code. For example, I have a program file that incorporates both of the example code, switching back and forth between using the code in strand mode and in matrix mode.

Thank you again for contributing! We will try to test and integrate the change as soon as we can, but be aware we have many GitHub repositories to manage and can't immediately respond to every request. There is no need to bump or check in on a pull request (it will clutter the discussion of the request).

Also don't be worried if the request is closed or not integrated--sometimes the priorities of Adafruit's GitHub code (education, ease of use) might not match the priorities of the pull request. Don't fret, the open source community thrives on forks and GitHub makes it easy to keep your changes in a forked repo.

After reviewing the guidelines above you can delete this text from the pull request.

TonyLHansen avatar Oct 14 '16 04:10 TonyLHansen